Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to assign _ #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dansanduleac
Copy link

Before this PR

There were some cases where we'd still try to set _ unsuccessfully, e.g. when sourcing the per-user nix.sh file when running a Nix installation.
See #19 (comment)

With some debugging messages printed out as to what it was returning from fenv.parse.diff:

Setting: NIX_SSL_CERT_FILE=/etc/ssl/certs/ca-certificates.crt
Setting: PATH=/Users/dansanduleac/.nix-profile/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin
Setting: _=/Users/dansanduleac/.nix-profile/bin/env
set: Tried to change the read-only variable “_”

After this PR

Always filter out _ from being set in fish.

Actually fixes what #19 tried to achieve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant